[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

Thu Jun 4 11:00:22 PDT 2020

jankratochvil marked 5 inline comments as done.
jankratochvil added inline comments.

================
Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf-sleb128.s:6
+# RUN: llvm-mc -g -dwarf-version=5 -triple x86_64-unknown-linux-gnu %s -filetype=obj > %t.o
+# RUN: ld.lld -m elf_x86_64 %t.o -o %t 
+# RUN: %lldb %t -o "p/x magic64" -o exit | FileCheck %s
----------------
jankratochvil wrote:
> labath wrote:
> > It's kinda weird (though very useful for tests) but lldb can open .o files too. You should be able to drop the linker and then the main function too.
> I admit it works with `.o` now but when I was testing it before it did not (despite GDB could open such `.o` file).
I have thus removed the `REQUIRES: lld`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81119/new/

https://reviews.llvm.org/D81119