[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 4 06:31:28 PDT 2020


labath added a comment.

The fix is good (thanks for tracking that down), but the test is way to complicated for what the fix does. A generic "can we show the DW_AT_const_value of a global variable" test might be useful -- I don't believe we have anything exactly like that  right now -- but it ought to be reduced as it contains a bunch of unrelated/unneeded stuff. However, that's strictly optional..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81119/new/

https://reviews.llvm.org/D81119





More information about the lldb-commits mailing list