[Lldb-commits] [PATCH] D80448: [lldb/Test] Add a trace method to replace (commented out) print statements.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 3 14:56:14 PDT 2020


JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:510
+        with recording(self, self.TraceOn()) as sbuf:
+            print(args, kwargs, file=sbuf)
+
----------------
mboehme wrote:
> labath wrote:
> > JDevlieghere wrote:
> > > This should be 
> > > ```
> > > print(*args, kwargs, file=sbuf)
> > > ```
> > Actually, it should be `print(*args, **kwargs, file=sbuf)`
> With both Python 2 and 3, this, is giving me an error:
> 
> ```
>     print(*args, **kwargs, file=sbuf)
>                          ^
> SyntaxError: invalid syntax
> ```
> 
> I believe this should be `print(*args, file=sbuf, **kwargs)`. Can you fix this?
Thanks, fixed by `5fa9c9d7f276b44b3da949382e0d0b5dbfd0ac8b`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80448/new/

https://reviews.llvm.org/D80448





More information about the lldb-commits mailing list