[Lldb-commits] [lldb] 96e7d19 - [lldb/Test] Don't print 'command invoked'

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 3 09:35:17 PDT 2020


Author: Jonas Devlieghere
Date: 2020-06-03T09:35:09-07:00
New Revision: 96e7d19a1f22f5d2018377b70b4c98e0f59ea412

URL: https://github.com/llvm/llvm-project/commit/96e7d19a1f22f5d2018377b70b4c98e0f59ea412
DIFF: https://github.com/llvm/llvm-project/commit/96e7d19a1f22f5d2018377b70b4c98e0f59ea412.diff

LOG: [lldb/Test] Don't print 'command invoked'

The different tools constructing dotest invocations (lit and
lldb-dotest) already print the command invocation so there's no need to
print it again in the dotest output.

My motivation for removing it is that it doesn't include the Python
interpreter and every time I accidentally copy it, the command fails
with an `ImportError`.

Differential revision: https://reviews.llvm.org/D81032

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/dotest.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py
index 80edad811bae..8668ddb0fb82 100644
--- a/lldb/packages/Python/lldbsuite/test/dotest.py
+++ b/lldb/packages/Python/lldbsuite/test/dotest.py
@@ -49,9 +49,6 @@
 from lldbsuite.test_event.event_builder import EventBuilder
 from ..support import seven
 
-def get_dotest_invocation():
-    return ' '.join(sys.argv)
-
 
 def is_exe(fpath):
     """Returns true if fpath is an executable."""
@@ -220,7 +217,6 @@ def parseOptionsAndInitTestdirs():
         parser = dotest_args.create_parser()
         args = parser.parse_args()
     except:
-        print(get_dotest_invocation())
         raise
 
     if args.unset_env_varnames:
@@ -243,10 +239,6 @@ def parseOptionsAndInitTestdirs():
     if args.set_inferior_env_vars:
         lldbtest_config.inferior_env = ' '.join(args.set_inferior_env_vars)
 
-    # Only print the args if being verbose.
-    if args.v:
-        print(get_dotest_invocation())
-
     if args.h:
         do_help = True
 
@@ -1081,7 +1073,6 @@ def run_suite():
         "\nSession logs for test failures/errors/unexpected successes"
         " will go into directory '%s'\n" %
         configuration.sdir_name)
-    sys.stderr.write("Command invoked: %s\n" % get_dotest_invocation())
 
     #
     # Invoke the default TextTestRunner to run the test suite


        


More information about the lldb-commits mailing list