[Lldb-commits] [lldb] de04375 - [lldb] Skip tests exercising DW_OP_GNU_entry_value with dsymutil

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 2 09:31:24 PDT 2020 

Author: Pavel Labath
Date: 2020-06-02T18:31:15+02:00
New Revision: de04375ac59e6e9290b361b3ffcf4558e688e8a9

URL: https://github.com/llvm/llvm-project/commit/de04375ac59e6e9290b361b3ffcf4558e688e8a9
DIFF: https://github.com/llvm/llvm-project/commit/de04375ac59e6e9290b361b3ffcf4558e688e8a9.diff

LOG: [lldb] Skip tests exercising DW_OP_GNU_entry_value with dsymutil

It seems that this opcode needs explicit support in dsymutil. Disable
these tests until that is implemented.

Added: 
    

Modified: 
    lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py
    lldb/test/API/functionalities/tail_call_frames/disambiguate_call_site/TestDisambiguateCallSite.py
    lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/TestDisambiguatePathsToCommonSink.py
    lldb/test/API/functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py
    lldb/test/API/functionalities/tail_call_frames/inlining_and_tail_calls/TestInliningAndTailCalls.py
    lldb/test/API/functionalities/tail_call_frames/thread_step_out_message/TestArtificialFrameStepOutMessage.py
    lldb/test/API/functionalities/tail_call_frames/unambiguous_sequence/TestUnambiguousTailCalls.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py b/lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py
index ccc737ca24de..4f294f555ec8 100644
--- a/lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py
+++ b/lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py
@@ -12,6 +12,7 @@
         name="BasicEntryValues_V5",
         build_dict=dict(CXXFLAGS_EXTRAS="-O2 -glldb"))
 
-lldbinline.MakeInlineTest(__file__, globals(), decorators=decorators,
+lldbinline.MakeInlineTest(__file__, globals(),
+        decorators=decorators+[skipIf(debug_info="dsym")],
         name="BasicEntryValues_GNU",
         build_dict=dict(CXXFLAGS_EXTRAS="-O2 -ggdb"))

diff  --git a/lldb/test/API/functionalities/tail_call_frames/disambiguate_call_site/TestDisambiguateCallSite.py b/lldb/test/API/functionalities/tail_call_frames/disambiguate_call_site/TestDisambiguateCallSite.py
index 99a2e762caa4..699263e7150c 100644
--- a/lldb/test/API/functionalities/tail_call_frames/disambiguate_call_site/TestDisambiguateCallSite.py
+++ b/lldb/test/API/functionalities/tail_call_frames/disambiguate_call_site/TestDisambiguateCallSite.py
@@ -1,9 +1,10 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-decorators = [decorators.skipUnlessHasCallSiteInfo,
+decor = [decorators.skipUnlessHasCallSiteInfo,
          decorators.skipIf(dwarf_version=['<', '4'])]
 lldbinline.MakeInlineTest(__file__, globals(), name="DisambiguateCallSite_V5",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decor)
 lldbinline.MakeInlineTest(__file__, globals(), name="DisambiguateCallSite_GNU",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"),
+        decorators=decor+[decorators.skipIf(debug_info="dsym")])

diff  --git a/lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/TestDisambiguatePathsToCommonSink.py b/lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/TestDisambiguatePathsToCommonSink.py
index 815b5852d95c..80ed07992f1e 100644
--- a/lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/TestDisambiguatePathsToCommonSink.py
+++ b/lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/TestDisambiguatePathsToCommonSink.py
@@ -1,11 +1,12 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-decorators = [decorators.skipUnlessHasCallSiteInfo,
+decor = [decorators.skipUnlessHasCallSiteInfo,
          decorators.skipIf(dwarf_version=['<', '4'])]
 lldbinline.MakeInlineTest(__file__, globals(),
         name="DisambiguatePathsToCommonSink_V5",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decor)
 lldbinline.MakeInlineTest(__file__, globals(),
         name="DisambiguatePathsToCommonSink_GNU",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"),
+        decorators=decor+[decorators.skipIf(debug_info="dsym")])

diff  --git a/lldb/test/API/functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py b/lldb/test/API/functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py
index 3fc89201d9fd..9e4422cfa3ae 100644
--- a/lldb/test/API/functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py
+++ b/lldb/test/API/functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py
@@ -1,9 +1,10 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-decorators = [decorators.skipUnlessHasCallSiteInfo,
+decor = [decorators.skipUnlessHasCallSiteInfo,
          decorators.skipIf(dwarf_version=['<', '4'])]
 lldbinline.MakeInlineTest(__file__, globals(), name="DisambiguateTailCallSeq_V5",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decor)
 lldbinline.MakeInlineTest(__file__, globals(), name="DisambiguateTailCallSeq_GNU",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"),
+        decorators=decor+[decorators.skipIf(debug_info="dsym")])

diff  --git a/lldb/test/API/functionalities/tail_call_frames/inlining_and_tail_calls/TestInliningAndTailCalls.py b/lldb/test/API/functionalities/tail_call_frames/inlining_and_tail_calls/TestInliningAndTailCalls.py
index 2cdb49ee2b11..f09a6683137b 100644
--- a/lldb/test/API/functionalities/tail_call_frames/inlining_and_tail_calls/TestInliningAndTailCalls.py
+++ b/lldb/test/API/functionalities/tail_call_frames/inlining_and_tail_calls/TestInliningAndTailCalls.py
@@ -1,9 +1,10 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-decorators = [decorators.skipUnlessHasCallSiteInfo,
+decor = [decorators.skipUnlessHasCallSiteInfo,
          decorators.skipIf(dwarf_version=['<', '4'])]
 lldbinline.MakeInlineTest(__file__, globals(), name="InliningAndTailCalls_V5",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decor)
 lldbinline.MakeInlineTest(__file__, globals(), name="InliningAndTailCalls_GNU",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"),
+        decorators=decor+[decorators.skipIf(debug_info="dsym")])

diff  --git a/lldb/test/API/functionalities/tail_call_frames/thread_step_out_message/TestArtificialFrameStepOutMessage.py b/lldb/test/API/functionalities/tail_call_frames/thread_step_out_message/TestArtificialFrameStepOutMessage.py
index 2fbc6aea0601..ffb693bbb8f4 100644
--- a/lldb/test/API/functionalities/tail_call_frames/thread_step_out_message/TestArtificialFrameStepOutMessage.py
+++ b/lldb/test/API/functionalities/tail_call_frames/thread_step_out_message/TestArtificialFrameStepOutMessage.py
@@ -1,11 +1,12 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-decorators = [decorators.skipUnlessHasCallSiteInfo,
+decor = [decorators.skipUnlessHasCallSiteInfo,
          decorators.skipIf(dwarf_version=['<', '4'])]
 lldbinline.MakeInlineTest(__file__, globals(),
         name="ArtificialFrameStepOutMessage_V5",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decor)
 lldbinline.MakeInlineTest(__file__, globals(),
         name="ArtificialFrameStepOutMessage_GNU",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"),
+        decorators=decor+[decorators.skipIf(debug_info="dsym")])

diff  --git a/lldb/test/API/functionalities/tail_call_frames/unambiguous_sequence/TestUnambiguousTailCalls.py b/lldb/test/API/functionalities/tail_call_frames/unambiguous_sequence/TestUnambiguousTailCalls.py
index 8179e944947e..ae339265b8cf 100644
--- a/lldb/test/API/functionalities/tail_call_frames/unambiguous_sequence/TestUnambiguousTailCalls.py
+++ b/lldb/test/API/functionalities/tail_call_frames/unambiguous_sequence/TestUnambiguousTailCalls.py
@@ -1,9 +1,10 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-decorators = [decorators.skipUnlessHasCallSiteInfo,
+decor = [decorators.skipUnlessHasCallSiteInfo,
          decorators.skipIf(dwarf_version=['<', '4'])]
 lldbinline.MakeInlineTest(__file__, globals(), name="UnambiguousTailCalls_V5",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -glldb"), decorators=decor)
 lldbinline.MakeInlineTest(__file__, globals(), name="UnambiguousTailCalls_GNU",
-        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"), decorators=decorators)
+        build_dict=dict(CFLAGS_EXTRAS="-O2 -ggdb"),
+        decorators=decor+[decorators.skipIf(debug_info="dsym")])

More information about the lldb-commits mailing list