[Lldb-commits] [PATCH] D80793: [lldb][NFC] Make ClangExpressionSourceCode's wrapping logic more consistent
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 2 01:38:46 PDT 2020
labath added inline comments.
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h:41
+ /// Note that this is also used for static member functions of a C++ class.
> I would actually feel better have a separate enumerator for C++ static member functions and just having it fall-through when used. It would be self-documenting.
If it doesn't complicate the callers (i.e., they always know, or can easily find out, whether they are dealing with a static member or a non-member), I think that would be great.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits