[Lldb-commits] [PATCH] D80793: [lldb][NFC] Make ClangExpressionSourceCode's wrapping logic more consistent

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h:33-40
+    /// Wrapped in a member function of a C++ class.
+    CppMemberFunction,
+    /// Wrapped in a instance Objective-C method.
+    ObjCInstanceMethod,
+    /// Wrapped in a static Objective-C method.
+    ObjCStaticMethod,
+    /// Wrapped in a non-member function.
----------------
labath wrote:
> If I understand the code correctly, a c++ static member function is wrapped using the "function" approach. I think this is potentially confusing, so it would be good if the comments elaborated on it more (e.g. add "non-static" to the CppMemberFunction description, and explicitly mention static member functions in the "function" description).
It might be worth adding that we don't need to find the `this` for the C++ case unlike a non-static member function. This happens in `LookUpLldbClass`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80793/new/

https://reviews.llvm.org/D80793