[Lldb-commits] [PATCH] D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 1 02:05:47 PDT 2020

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D80807#2063196 <https://reviews.llvm.org/D80807#2063196>, @friss wrote:

> I would have committed this right away if it weren't for the slight change in behavior I wanted to point out. With this patch, if an input string ends with a `-`, it won't be consumed anymore. I suppose it doesn't matter.

That looks fine. A trailing `-` looks like someone wanted to add more bytes but then pressed return too early, so rejecting that sounds perfectly reasonable.

Since you've obviously been looking at this code lately, I've also added you the to D80755 <https://reviews.llvm.org/D80755>, for the mac perspective of accepting "uuid"s with different lengths.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list