[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

[Pavel Labath via Phabricator via lldb-commits]

labath updated this revision to Diff 267179.
labath marked an inline comment as done.
labath added a comment.

- add -1
- add -ggdb flavours for inline tail call tests, drop -glldb from the others. The choice is fairly arbitrary. I don't believe we should be doing combinatorial testing at this level, so I did not want to enable all of them. Enabling inline tests was easy because I had muscle memory for it. For the rest, dropping -glldb means that the gnu flavour will be tested on platforms that default to -ggdb.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80519/new/

https://reviews.llvm.org/D80519

Files:
  lldb/source/Expression/DWARFExpression.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py
  lldb/test/API/functionalities/param_entry_vals/basic_entry_values/main.cpp
  lldb/test/API/functionalities/tail_call_frames/ambiguous_tail_call_seq1/Makefile
  lldb/test/API/functionalities/tail_call_frames/ambiguous_tail_call_seq1/TestAmbiguousTailCallSeq1.py
  lldb/test/API/functionalities/tail_call_frames/ambiguous_tail_call_seq2/Makefile
  lldb/test/API/functionalities/tail_call_frames/ambiguous_tail_call_seq2/TestAmbiguousTailCallSeq2.py
  lldb/test/API/functionalities/tail_call_frames/cross_dso/Makefile
  lldb/test/API/functionalities/tail_call_frames/cross_dso/One.mk
  lldb/test/API/functionalities/tail_call_frames/cross_dso/Two.mk
  lldb/test/API/functionalities/tail_call_frames/cross_object/Makefile
  lldb/test/API/functionalities/tail_call_frames/disambiguate_call_site/Makefile
  lldb/test/API/functionalities/tail_call_frames/disambiguate_call_site/TestDisambiguateCallSite.py
  lldb/test/API/functionalities/tail_call_frames/disambiguate_call_site/main.cpp
  lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/Makefile
  lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/TestDisambiguatePathsToCommonSink.py
  lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/main.cpp
  lldb/test/API/functionalities/tail_call_frames/disambiguate_tail_call_seq/Makefile
  lldb/test/API/functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py
  lldb/test/API/functionalities/tail_call_frames/disambiguate_tail_call_seq/main.cpp
  lldb/test/API/functionalities/tail_call_frames/inlining_and_tail_calls/Makefile
  lldb/test/API/functionalities/tail_call_frames/inlining_and_tail_calls/TestInliningAndTailCalls.py
  lldb/test/API/functionalities/tail_call_frames/inlining_and_tail_calls/main.cpp
  lldb/test/API/functionalities/tail_call_frames/sbapi_support/Makefile
  lldb/test/API/functionalities/tail_call_frames/thread_step_out_message/Makefile
  lldb/test/API/functionalities/tail_call_frames/thread_step_out_message/TestArtificialFrameStepOutMessage.py
  lldb/test/API/functionalities/tail_call_frames/thread_step_out_message/main.cpp
  lldb/test/API/functionalities/tail_call_frames/thread_step_out_or_return/Makefile
  lldb/test/API/functionalities/tail_call_frames/unambiguous_sequence/Makefile
  lldb/test/API/functionalities/tail_call_frames/unambiguous_sequence/TestUnambiguousTailCalls.py
  lldb/test/API/functionalities/tail_call_frames/unambiguous_sequence/main.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80519.267179.patch
Type: text/x-patch
Size: 27394 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200529/7994d5ac/attachment-0001.bin>