[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in SBTarget::AddModule

[Jaroslav Sevcik via Phabricator via lldb-commits]

jarin marked an inline comment as done.
jarin added inline comments.


================
Comment at: lldb/source/API/SBTarget.cpp:1593
+      llvm::StringRef rest =
+          UUID::DecodeUUIDBytesFromString(uuid_str, bytes, 20);
+      // If the UUID string was consumed and it is not empty, let us use it for
----------------
The four lines above should perhaps be a method of UUID. Something like SetFromStringRef, but for any size. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80755/new/

https://reviews.llvm.org/D80755