[Lldb-commits] [lldb] fe9d844 - [lldb/Test] Generate YAML binary in build directory

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Wed May 27 12:08:51 PDT 2020


Author: Jonas Devlieghere
Date: 2020-05-27T12:08:41-07:00
New Revision: fe9d8442e0dfc8c83e9a0a31f5079e7a70b54d9d

URL: https://github.com/llvm/llvm-project/commit/fe9d8442e0dfc8c83e9a0a31f5079e7a70b54d9d
DIFF: https://github.com/llvm/llvm-project/commit/fe9d8442e0dfc8c83e9a0a31f5079e7a70b54d9d.diff

LOG: [lldb/Test] Generate YAML binary in build directory

Although it's not entirely clear to me why, this test was generating its
binary in the source directory instead of the build directory. This
patch fixes that following the same approach as other tests.

Added: 
    

Modified: 
    lldb/test/API/functionalities/show_location/TestShowLocationDwarf5.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/show_location/TestShowLocationDwarf5.py b/lldb/test/API/functionalities/show_location/TestShowLocationDwarf5.py
index 1d4bc6f13450..76d24d5d4e52 100644
--- a/lldb/test/API/functionalities/show_location/TestShowLocationDwarf5.py
+++ b/lldb/test/API/functionalities/show_location/TestShowLocationDwarf5.py
@@ -14,17 +14,9 @@ class TestTargetSourceMap(TestBase):
     def test_source_map(self):
         # Set the target soure map to map "./" to the current test directory.
         yaml_path = os.path.join(self.getSourceDir(), "a.yaml")
-        yaml_base, ext = os.path.splitext(yaml_path)
-        obj_path = self.getBuildArtifact(yaml_base)
+        obj_path = self.getBuildArtifact('a.out')
         self.yaml2obj(yaml_path, obj_path)
 
-        def cleanup():
-            if os.path.exists(obj_path):
-                os.unlink(obj_path)
-
-        # Execute the cleanup function during test case tear down.
-        self.addTearDownHook(cleanup)
-
         # Create a target with the object file we just created from YAML
         target = self.dbg.CreateTarget(obj_path)
 


        


More information about the lldb-commits mailing list