[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

[Konrad Wilhelm Kleine via Phabricator via lldb-commits]

kwk marked 2 inline comments as done.
kwk added inline comments.


================
Comment at: lldb/test/Shell/Breakpoint/Inputs/search-support-files.h:1
+int inlined_42() { return 42; }
----------------
labath wrote:
> Calling this `inlined` is misleading. The function won't get inlined anywhere at -O0, and in fact your test would not work if it got inlined. Maybe just call it `function_in_header` ?
Thank you for finding this. My understanding needs a lot of sharpening I guess.


================
Comment at: lldb/test/Shell/Breakpoint/search-support-files.test:15
+# CHECK: (lldb) breakpoint set -n inlined_42
+# CHECK-NEXT: Breakpoint 1: where = dummy.out`inlined_42() + 4 at search-support-files.h:1:20, address = 0x0{{.*}}
+
----------------
labath wrote:
> These check lines hardcode too much stuff. The `+4` thingy can easily change due to unrelated codegen changes, and even the `:1:20` seems unnecessarily strict.
> Maybe something like this would be enough:
> ```
> CHECK-NEXT: Breakpoint 1: where = {{.8}}`inlined_42{{.*}} at search-support-files.h
> ```
Yes, you're right. Although I don't know what  `{{.8}}` does in this case. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74136/new/

https://reviews.llvm.org/D74136