[Lldb-commits] [lldb] e1d2cec - [lldb/Test] Cleanup TestSymbolTable.py (NFC)

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2020-05-26T13:17:43-07:00
New Revision: e1d2cecec5197af7104e4c50e6aed4313d512cda

URL: https://github.com/llvm/llvm-project/commit/e1d2cecec5197af7104e4c50e6aed4313d512cda
DIFF: https://github.com/llvm/llvm-project/commit/e1d2cecec5197af7104e4c50e6aed4313d512cda.diff

LOG: [lldb/Test] Cleanup TestSymbolTable.py (NFC)

Added: 
    

Modified: 
    lldb/test/API/lang/objc/foundation/TestSymbolTable.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/lang/objc/foundation/TestSymbolTable.py b/lldb/test/API/lang/objc/foundation/TestSymbolTable.py
index f3331e829c27..df4860f14826 100644
--- a/lldb/test/API/lang/objc/foundation/TestSymbolTable.py
+++ b/lldb/test/API/lang/objc/foundation/TestSymbolTable.py
@@ -17,8 +17,7 @@ class FoundationSymtabTestCase(TestBase):
                     '-[MyString dealloc]',
                     '-[MyString description]',
                     '-[MyString descriptionPauses]',     # synthesized property
-                    # synthesized property
-                    '-[MyString setDescriptionPauses:]',
+                    '-[MyString setDescriptionPauses:]', # synthesized property
                     'Test_Selector',
                     'Test_NSString',
                     'Test_MyString',
@@ -31,14 +30,13 @@ def test_with_python_api(self):
         """Test symbol table access with Python APIs."""
         self.build()
         exe = self.getBuildArtifact("a.out")
-        self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
-
         target = self.dbg.CreateTarget(exe)
         self.assertTrue(target, VALID_TARGET)
 
         # Launch the process, and do not stop at the entry point.
         process = target.LaunchSimple(
             None, None, self.get_process_working_directory())
+        self.assertTrue(process, PROCESS_IS_VALID)
 
         # Create the filespec by which to locate our a.out module.
         filespec = lldb.SBFileSpec(exe, False)
@@ -51,14 +49,14 @@ def test_with_python_api(self):
         expected_symbols = set(self.symbols_list)
         for symbol in module:
             self.assertTrue(symbol, VALID_SYMBOL)
-            #print("symbol:", symbol)
+            self.trace("symbol:", symbol)
             name = symbol.GetName()
             if name in expected_symbols:
-                #print("Removing %s from known_symbols %s" % (name, expected_symbols))
+                self.trace("Removing %s from known_symbols %s" % (name, expected_symbols))
                 expected_symbols.remove(name)
 
         # At this point, the known_symbols set should have become an empty set.
         # If not, raise an error.
-        #print("symbols unaccounted for:", expected_symbols)
+        self.trace("symbols unaccounted for:", expected_symbols)
         self.assertTrue(len(expected_symbols) == 0,
                         "All the known symbols are accounted for")