[Lldb-commits] [lldb] 053b063 - [lldb] Increase timeout in TestExitDuringExpression

[Pavel Labath via lldb-commits]

On 22/05/2020 19:11, Jim Ingham wrote:
> I set the timeouts low just to keep the test from taking too long.  Beyond that there’s no harm in bumping them up till they pass consistently.
> 
> I messed with the timeouts and reran the test a bunch of times till it was stable for me, but I have a pretty fast mac, so apparently that wasn’t a good test…
> 
> I don’t see a way to do this without timeouts, however…
> 
> Thanks for fixing this.
> 
> Jim
> 

While farming buildbots, I've learned that it's really hard to
*under*estimate the time it takes to do something. Like, you need to go
_at least_ 10x the time it takes to make the test reliable for yourself,
otherwise there will be some cosmic fluke in the 99.99-th percentile,
which will sometimes cause the test to fail. The smaller the absolute
value, the bigger the fudge factor needs to be.

The only really problematic piece here was the time it takes to run the
full expression. If we substantially increased just that, then the test
would succeed, even though it may not have always tested the path that
it wanted to test. But 100ms is still short enough to not need to worry
about that.

pl