[Lldb-commits] [PATCH] D80448: [lldb/Test] Add a trace method to replace (commented out) print statements.

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Yes, this is a good idea. It might it also nice to go through the `if self.traceOn()` calls and see which ones can be replaced by this function.



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:510
+        with recording(self, self.TraceOn()) as sbuf:
+            print(args, kwargs, file=sbuf)
+
----------------
JDevlieghere wrote:
> This should be 
> ```
> print(*args, kwargs, file=sbuf)
> ```
Actually, it should be `print(*args, **kwargs, file=sbuf)`


================
Comment at: lldb/test/API/lang/c/register_variables/TestRegisterVariables.py:32
         return False
     # else:
+        self.trace("value is {}".format(value))
----------------
uncomment this as well


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80448/new/

https://reviews.llvm.org/D80448