[Lldb-commits] [PATCH] D80345: [DwarfExpression] Support entry values for indirect parameters

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h:151
+    IndirectValue = 1 << 1,
+    CallSiteParamValue = 1 << 2
+  };
----------------
I'm going to be pedantic now: Should this be Indirect instead of IndirectValue? I.e., can there be non-values (= modifyable locations) that are indirect?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h:162
+  void adjustLocationKind(const MachineLocation &Loc,
+                          const DIExpression *DIExpr);
+
----------------
"adjust" sounds like you could call this more than once. Should it be "set" or "initialize"? Or even be the constructor?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80345/new/

https://reviews.llvm.org/D80345