[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

Ilya Bukonkin via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 21 15:12:04 PDT 2020

fallkrum added a comment.

In D80112#2049657 <https://reviews.llvm.org/D80112#2049657>, @JDevlieghere wrote:

> In D80112#2048805 <https://reviews.llvm.org/D80112#2048805>, @fallkrum wrote:
> > Anybody there? Do you see me?
> Unless this change is somehow urgent, the common courtesy ‘ping’ rate is once a week [1][2]. I'm sure Jim or Greg will take a look when they can.
> Would it be possible to add a test for this so it doesn't regress in the future? For example a test that would fail with TSan would be sufficient.
> [1] https://llvm.org/docs/Contributing.html#how-to-submit-a-patch
>  [2] https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity

Thanks for the answer, I don't think it is urgent.
Are there any docs on how to write tests for lldb? I found unit tests (lldb/unittests) written in c++ and tests (lldb/test) written in Python. 
Tried to find tests for Thread class to add check for my editing but there is no such a tests. It is very unclear for me in which way TSan
can be helpful in this situation?

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list