[Lldb-commits] [lldb] f67f9e8 - Revert "[lldb/test] Disable NSDate format check under _WIN32"
Dmitri Gribenko via lldb-commits
lldb-commits at lists.llvm.org
Wed May 20 03:46:53 PDT 2020
Author: Dmitri Gribenko
Date: 2020-05-20T12:44:19+02:00
New Revision: f67f9e86e86e68d4cbc05ef8d6ffd0cb33246d45
URL: https://github.com/llvm/llvm-project/commit/f67f9e86e86e68d4cbc05ef8d6ffd0cb33246d45
DIFF: https://github.com/llvm/llvm-project/commit/f67f9e86e86e68d4cbc05ef8d6ffd0cb33246d45.diff
LOG: Revert "[lldb/test] Disable NSDate format check under _WIN32"
This reverts commit e3aa4cd9dbcee6441f51102e3958c35321698c67. It is a
follow-up to b783f70a42575a5d9147bea1ac97e872370fe55b, which I'm
reverting -- see the explanation in that revert.
Added:
Modified:
lldb/unittests/DataFormatter/MockTests.cpp
Removed:
################################################################################
diff --git a/lldb/unittests/DataFormatter/MockTests.cpp b/lldb/unittests/DataFormatter/MockTests.cpp
index 1185d7bf2c9c..752e3987dac9 100644
--- a/lldb/unittests/DataFormatter/MockTests.cpp
+++ b/lldb/unittests/DataFormatter/MockTests.cpp
@@ -37,10 +37,6 @@ TEST(DataFormatterMockTest, NSDate) {
EXPECT_EQ(formatDateValue(std::numeric_limits<time_t>::max()), llvm::None);
EXPECT_EQ(formatDateValue(std::numeric_limits<time_t>::min()), llvm::None);
- // FIXME: The formatting result is wrong on Windows because we adjust the
- // epoch when _WIN32 is defined (see GetOSXEpoch).
-#ifndef _WIN32
EXPECT_TRUE(
llvm::StringRef(*formatDateValue(0)).startswith("2001-01-01 00:00:00"));
-#endif
}
More information about the lldb-commits
mailing list