[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch
Vedant Kumar via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon May 18 13:33:55 PDT 2020
vsk marked 2 inline comments as done.
vsk added a comment.
Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:801-804
+ // this snippet of code assumes that time_t == seconds since Jan-1-1970 this
+ // is generally true and POSIXly happy, but might break if a library vendor
+ // decides to get creative
+ time_t epoch = GetOSXEpoch();
> I think you can drop this comment [you just moved it, but it feels irrelevant at this point because there's only one vendor].
I'll fix this before committing.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits