[Lldb-commits] [PATCH] D80104: [LLDB] Remove code duplication from RegisterContextPOSIX_*

Muhammad Omair Javaid via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun May 17 23:57:19 PDT 2020


omjavaid created this revision.
omjavaid added a reviewer: labath.
Herald added subscribers: atanasyan, kbarton, kristof.beyls, nemanjai.

This patch aims to remove multiple copies of GetByteOrder() and ConvertRegisterKindToRegisterNumber used in various versions of RegisterContextPOSIX_*.

Both register implementations are move to RegisterContext class which is parent of RegisterContextPOSIX_* classes.

Built and tested on x86_64-linux-gnu, aarch64-linux-gnu and arm-linux-gnueabihf targets.


https://reviews.llvm.org/D80104

Files:
  lldb/include/lldb/Target/RegisterContext.h
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm.cpp
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm.h
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.h
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.cpp
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.h
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.h
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.cpp
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.h
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_s390x.cpp
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_s390x.h
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.h
  lldb/source/Target/RegisterContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80104.264542.patch
Type: text/x-patch
Size: 17345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200518/2a3a2047/attachment-0001.bin>


More information about the lldb-commits mailing list