[Lldb-commits] [lldb] 7c89297 - Correct the argument list of command `breakpoint read`

[Raphael Isemann via lldb-commits]

Author: Gongyu Deng
Date: 2020-05-15T09:00:05+02:00
New Revision: 7c89297cf7eecd52327915de587df8183793afac

URL: https://github.com/llvm/llvm-project/commit/7c89297cf7eecd52327915de587df8183793afac
DIFF: https://github.com/llvm/llvm-project/commit/7c89297cf7eecd52327915de587df8183793afac.diff

LOG: Correct the argument list of command `breakpoint read`

Summary: Command `breakpoint read` should not accept breakpoint ids as
arguments, and in fact, it is not implemented to deal with breakpoint id
arguments either. So this patch is to correct the argument list of this
command so that the help text won't misguide users.

Reviewers: teemperor, JDevlieghere, jingham

Reviewed By: teemperor, JDevlieghere

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D79722

Added: 
    

Modified: 
    lldb/source/Commands/CommandObjectBreakpoint.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Commands/CommandObjectBreakpoint.cpp b/lldb/source/Commands/CommandObjectBreakpoint.cpp
index fbd96c2c5ef5..be7ef8a1b60b 100644
--- a/lldb/source/Commands/CommandObjectBreakpoint.cpp
+++ b/lldb/source/Commands/CommandObjectBreakpoint.cpp
@@ -2034,14 +2034,7 @@ class CommandObjectBreakpointRead : public CommandObjectParsed {
                             "Read and set the breakpoints previously saved to "
                             "a file with \"breakpoint write\".  ",
                             nullptr),
-        m_options() {
-    CommandArgumentEntry arg;
-    CommandObject::AddIDsArgumentData(arg, eArgTypeBreakpointID,
-                                      eArgTypeBreakpointIDRange);
-    // Add the entry for the first argument for this command to the object's
-    // arguments vector.
-    m_arguments.push_back(arg);
-  }
+        m_options() {}
 
   ~CommandObjectBreakpointRead() override = default;