[Lldb-commits] [lldb] 2d6f4fe - [lldb/Test] Skip test using files to synchronize.

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu May 14 13:09:03 PDT 2020


Author: Jonas Devlieghere
Date: 2020-05-14T13:08:56-07:00
New Revision: 2d6f4fec07292f1d2f77cbbf5188de3838a70b78

URL: https://github.com/llvm/llvm-project/commit/2d6f4fec07292f1d2f77cbbf5188de3838a70b78
DIFF: https://github.com/llvm/llvm-project/commit/2d6f4fec07292f1d2f77cbbf5188de3838a70b78.diff

LOG: [lldb/Test] Skip test using files to synchronize.

Files written by the inferior are not captured by the reproducers and
the inferior doesn't actually run during replay.

Added: 
    

Modified: 
    lldb/test/API/commands/settings/TestSettings.py
    lldb/test/API/commands/settings/quoting/TestQuoting.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/settings/TestSettings.py b/lldb/test/API/commands/settings/TestSettings.py
index 29360856a735..fc872f6240fe 100644
--- a/lldb/test/API/commands/settings/TestSettings.py
+++ b/lldb/test/API/commands/settings/TestSettings.py
@@ -203,10 +203,12 @@ def test_disassembler_settings(self):
                     substrs=["5ah"])
 
     @skipIfDarwinEmbedded   # <rdar://problem/34446098> debugserver on ios etc can't write files
+    @skipIfReproducer
     def test_run_args_and_env_vars(self):
         self.do_test_run_args_and_env_vars(use_launchsimple=False)
 
     @skipIfDarwinEmbedded   # <rdar://problem/34446098> debugserver on ios etc can't write files
+    @skipIfReproducer
     def test_launchsimple_args_and_env_vars(self):
         self.do_test_run_args_and_env_vars(use_launchsimple=True)
 
@@ -286,6 +288,7 @@ def do_test_run_args_and_env_vars(self, use_launchsimple):
                 "Environment variable 'MY_ENV_VAR' successfully passed."])
 
     @skipIfRemote  # it doesn't make sense to send host env to remote target
+    @skipIfReproducer
     def test_pass_host_env_vars(self):
         """Test that the host env vars are passed to the launched process."""
         self.build()
@@ -382,6 +385,7 @@ def unset_env_variables():
                 "The host environment variable 'MY_HOST_ENV_VAR2' successfully passed."])
 
     @skipIfDarwinEmbedded   # <rdar://problem/34446098> debugserver on ios etc can't write files
+    @skipIfReproducer
     def test_set_error_output_path(self):
         """Test that setting target.error/output-path for the launched process works."""
         self.build()

diff  --git a/lldb/test/API/commands/settings/quoting/TestQuoting.py b/lldb/test/API/commands/settings/quoting/TestQuoting.py
index d7581951a147..a415ea8ee247 100644
--- a/lldb/test/API/commands/settings/quoting/TestQuoting.py
+++ b/lldb/test/API/commands/settings/quoting/TestQuoting.py
@@ -64,6 +64,7 @@ def test_bare_single(self):
     def test_bare_double(self):
         self.do_test_args('a\\"b', 'a"b\0')
 
+    @skipIfReproducer # Reproducers don't know about output.txt
     def do_test_args(self, args_in, args_out):
         """Test argument parsing. Run the program with args_in. The program dumps its arguments
         to stdout. Compare the stdout with args_out."""


        


More information about the lldb-commits mailing list