[Lldb-commits] [lldb] deea174 - [lldb/gdb-remote] Change default value of use-libraries-svr4 to true

[Pavel Labath via lldb-commits]

Author: Pavel Labath
Date: 2020-05-14T12:17:37+02:00
New Revision: deea174ee508c84652785e55f54c81fd1fba492c

URL: https://github.com/llvm/llvm-project/commit/deea174ee508c84652785e55f54c81fd1fba492c
DIFF: https://github.com/llvm/llvm-project/commit/deea174ee508c84652785e55f54c81fd1fba492c.diff

LOG: [lldb/gdb-remote] Change default value of use-libraries-svr4 to true

This setting was added last year, defaulting to false. There have been
no bug reports about the svr4 code path since then, and the using this
packet is definitely faster than walking the module list from lldb.

Set the default value of the setting to true, as that is a better
default. Users can still change it back if encountering problems, or we
can revert the change as well, in case of bigger issues.

I also add a note to the setting description that it is only effective
if lldb is built with xml support.

Added: 
    

Modified: 
    lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td
index 9cbe3d40ca2c..d4c3c8b94b7e 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td
@@ -11,8 +11,8 @@ let Definition = "processgdbremote" in {
     Desc<"The file that provides the description for remote target registers.">;
   def UseSVR4: Property<"use-libraries-svr4", "Boolean">,
     Global,
-    DefaultFalse,
-    Desc<"If true, the libraries-svr4 feature will be used to get a hold of the process's loaded modules.">;
+    DefaultTrue,
+    Desc<"If true, the libraries-svr4 feature will be used to get a hold of the process's loaded modules. This setting is only effective if lldb was build with xml support.">;
   def UseGPacketForReading: Property<"use-g-packet-for-reading", "Boolean">,
     Global,
     DefaultFalse,