[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

[Saleem Abdulrasool via Phabricator via lldb-commits]

compnerd added a comment.

WeakODR requires that the symbol actually be discarded if not referenced.  This will preserve the symbol even if unreferenced will it not?  One approach might be to just create a `DenseMap` and check for any references and mark is as preserved otherwise just drop it.  However, it _is_ ODR, which means that if it ever gets instantiated, we are well within our rights to give you the second definition rather than the first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78972/new/

https://reviews.llvm.org/D78972