[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

Wed May 13 07:00:13 PDT 2020

labath added a reviewer: jingham.
labath marked 3 inline comments as done.
labath added a comment.

In D79789#2032008 <https://reviews.llvm.org/D79789#2032008>, @jingham wrote:

> Instead of just printing out the range, can we print out the disassemble command you would run to actually disassemble the range?
>
> Also, I think we should add a --force option since if you were using this in a script you wouldn't get a chance to respond to the error.

Yes, I've been thinking about a --force option too. You're right that this is a friendlier interface for scripting purposes.

The reason I wanted to print the range was to give the user a chance to pause and say "yes, I really don't want to disassemble all of *that*". With a --force option, do you think it's necessary to print the repeat command? It seems that doing a "<Up>--force<Return> would be more straight-forward than copy-pasting a chunk of text (and I don't believe we currently have a way to fetch the original command line from within a CommandObject implementation).

================
Comment at: lldb/test/Shell/Commands/command-disassemble-process.yaml:93
     Value:           0x0000000000004002
-    Size:            0x0000000000000008
+    Size:            [[MAIN_SIZE]]
 ProgramHeaders:
----------------
JDevlieghere wrote:
> Cool, I didn't realize this was possible. 
It's a very recent addition. It runs as a textual pre-processing step, so you can use it to do all the evi^H^H^Hnice things you can with a c preprocessor.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79789/new/

https://reviews.llvm.org/D79789