[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Looks good to me.



================
Comment at: lldb/source/Commands/CommandObjectDisassemble.cpp:225
+             Address::DumpStyleFileAddress);
+  msg << ". To disassemble, specify an instruction count limit, or start/stop "
+         "addresses.";
----------------
nit: I don't think we need either of these commas. 


================
Comment at: lldb/test/Shell/Commands/command-disassemble-process.yaml:93
     Value:           0x0000000000004002
-    Size:            0x0000000000000008
+    Size:            [[MAIN_SIZE]]
 ProgramHeaders:
----------------
Cool, I didn't realize this was possible. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79789/new/

https://reviews.llvm.org/D79789