[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

[António Afonso via Phabricator via lldb-commits]

aadsm added a comment.

> I gotta say I don't understand the difference between "exit" and "terminate" commands, as both seem to happen pretty at once. Is the difference that "exit" commands are run only when the inferior exits freely on its own, and not when we forcefully kill it? And that "terminate" cmds are run in both cases?

Yeah, just like said, the exit event (and commands) only happen when the program normally exits (with an exit code). However, I want to run commands when the debugging session is over, which might not necessarily mean the debuggee has ended (forcefully or not), only that we stopped debugging it. My main goal is to collect stats of the debugging session that has just ended.

> If you say that they are useful, then sure, I don't see a reason to not do this, though it seems to me like this will be confusing, and would be worth documenting somewhere. Maybe in that json file (I forgot where it's stored) which defines the protocol extensions used by lldb-vscode?

Ah yes, I'll add that to the package.json definition of the extension and also the README.md.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79726/new/

https://reviews.llvm.org/D79726