[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

[Alexandre Ganea via Phabricator via lldb-commits]

aganea updated this revision to Diff 263450.
aganea added a comment.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Reopening because I had to revert.

- Fix lldb's variables.test
- Fix type lowering, as described here: D79512 <https://reviews.llvm.org/D79512>
- Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur during UDT emission, as suggested by @rnk


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79447/new/

https://reviews.llvm.org/D79447

Files:
  lldb/test/Shell/SymbolFile/PDB/variables.test
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
  llvm/test/DebugInfo/COFF/global-constants.ll
  llvm/test/DebugInfo/COFF/global_visibility.ll
  llvm/test/DebugInfo/COFF/globals.ll
  llvm/test/DebugInfo/COFF/types-array-unsized.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79447.263450.patch
Type: text/x-patch
Size: 73275 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200512/1f5686d2/attachment-0001.bin>