[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 12 06:24:55 PDT 2020


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks great now, just a small tweak to the test case.



================
Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_TAG_basic_type_DW_ATE_UTF_nonC.ll:19
+;
+; RUN: %clang_host -g -o %t %s
+; RUN: %lldb %t -o 'type lookup string' -o exit | FileCheck %s
----------------
Now that we're not running the binary, you can remove the `main` function, and replace `%clang_host` with `%clang --target original-ldc2-target -c`. Without that, we might as well have run the binary, because if it compiles for the host, chances are it would have run correctly too...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79559/new/

https://reviews.llvm.org/D79559





More information about the lldb-commits mailing list