[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

[walter erquinigo via Phabricator via lldb-commits]

wallace added a comment.

I don't know if terminate is the best name, as it could seem related to the inferior. What about finalize? It reminds me of the try/catch/finalize words, and it's harder to associate it with the inferior's own exit event.



================
Comment at: lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py:49-67
+    @skipIfDarwin
     @skipIfRemote
     def test_by_pid(self):
         '''
             Tests attaching to a process by process ID.
         '''
         self.build_and_create_debug_adaptor()
----------------
why did you add these?


================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2873-2876
   // We must terminate the debugger in a thread before the C++ destructor
   // chain messes everything up.
   lldb::SBDebugger::Terminate();
   return 0;
----------------
Instead of having to invoke the terminate commands from two different places, what about executing them here? That way you can guarantee that they will be executed for sure and they won' be executed twice (I'm still not certain that your two call sites are mutually exclusive)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79726/new/

https://reviews.llvm.org/D79726