[Lldb-commits] [PATCH] D79645: [lldb/test] Fix for flakiness in TestNSDictionarySynthetic

[Vedant Kumar via Phabricator via lldb-commits]

vsk marked 2 inline comments as done.
vsk added inline comments.


================
Comment at: lldb/test/API/lldbtest.py:123
             # In Python 2, string objects can contain Unicode characters.
-            out = out.decode('utf-8')
-            err = err.decode('utf-8')
+            out = out.decode('utf-8', 'replace')
+            err = err.decode('utf-8', 'replace')
----------------
shafik wrote:
> Maybe add a comment as to why we are using `'replace'` and LLDB and python implementation disagree and this works for now.
Definitely, I'll add this before committing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79645/new/

https://reviews.llvm.org/D79645