[Lldb-commits] [lldb] c9537b9 - [lldb/debugserver] Include TargetConditionals.h where needed
Fred Riss via lldb-commits
lldb-commits at lists.llvm.org
Sat May 9 10:35:18 PDT 2020
Author: Fred Riss
Date: 2020-05-09T10:12:17-07:00
New Revision: c9537b9cc862b7ec1ba502043e42bc6ebd24dec0
URL: https://github.com/llvm/llvm-project/commit/c9537b9cc862b7ec1ba502043e42bc6ebd24dec0
DIFF: https://github.com/llvm/llvm-project/commit/c9537b9cc862b7ec1ba502043e42bc6ebd24dec0.diff
LOG: [lldb/debugserver] Include TargetConditionals.h where needed
MachProcess.mm uses a TARGET_OS_ macro without directly including
TargetConditionals.h. This currently works as we get the header
as an indirect dependency, but might not in the future.
I just spent some time investigating an internal regression
caused by a similar issue, so I audited the codebase for such
cases.
Added:
Modified:
lldb/tools/debugserver/source/MacOSX/MachProcess.mm
Removed:
################################################################################
diff --git a/lldb/tools/debugserver/source/MacOSX/MachProcess.mm b/lldb/tools/debugserver/source/MacOSX/MachProcess.mm
index 032f2a877903..95060c552f25 100644
--- a/lldb/tools/debugserver/source/MacOSX/MachProcess.mm
+++ b/lldb/tools/debugserver/source/MacOSX/MachProcess.mm
@@ -34,6 +34,7 @@
#include <chrono>
#include <map>
+#include <TargetConditionals.h>
#import <Foundation/Foundation.h>
#include "DNBDataRef.h"
More information about the lldb-commits
mailing list