[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

[Med Ismail Bennani via Phabricator via lldb-commits]

mib updated this revision to Diff 262999.
mib added a comment.

With the first implementation, I thought it'd be a good idea to have separate Command Objects for `platform shell` and `shell` because I was imagining the latter could be more "powerful": `shell` could have an interactive mode like the `script` command, which might not be as relevant for `platform shell` when debugging a remote target.

That was my original idea, but I agree we should avoid code duplication, so here is a different implementation following @jingham's suggestions. `shell` is an alias to `platform shell -h --` in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79659/new/

https://reviews.llvm.org/D79659

Files:
  lldb/source/Commands/CommandObjectPlatform.cpp
  lldb/source/Commands/Options.td
  lldb/source/Interpreter/CommandInterpreter.cpp
  lldb/test/API/commands/shell/TestShellCommand.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79659.262999.patch
Type: text/x-patch
Size: 5586 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200509/858c8d03/attachment-0001.bin>