[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

[Pavel Labath via Phabricator via lldb-commits]

labath added a reviewer: teemperor.
labath added a comment.

The ValueObject change looks very worrying to me. The ability to pretty-print incomplete types seems pretty useful, but the implementation of that looks a bit... scary. I mean you're not even checking whether the incomplete type is a struct or an enum. And the effect of forcefully creating a empty struct has impact outside of the pretty-printer. Maybe it would be better if we thought the valueobject/pretty-printer machinery to work with incomplete types?

Raphael, what do you make of all of this?

Also would it be possible to test the ValueObject functionality on a c++ test (an incomplete c++ type with a custom pretty printer), so that test can run every where?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79554/new/

https://reviews.llvm.org/D79554