[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: vsk, djtodoro, dblaikie.
Herald added a project: LLDB.

This function rewrites the test to be (hopefully) less susceptible to
codegen changes and re-enables it.

The most interesting changes are:

- use an __attribute__((optnone)) function instead of a volatile asm to "use" a value. This isn't strictly necessary, but it makes the function simpler while achieving the same effect.
- use a call to a function with the exact same signature instead of a volatile asm to "destroy" arguments. This makes the independent of the ABI, and (together with avoiding the usage of the arguments after the call) ensures that the compiler has no reason to move the argument from its initial register (previously we needed to guess where will the compiler store the arguments).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79491

Files:
  lldb/test/API/functionalities/param_entry_vals/basic_entry_values_x86_64/TestBasicEntryValuesX86_64.py
  lldb/test/API/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79491.262373.patch
Type: text/x-patch
Size: 8492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200506/4a094cb8/attachment.bin>