[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I think this is right, but it looks like you uploaded a diff based on the previous version of the patch instead of the master.

In D79364#2020728 <https://reviews.llvm.org/D79364#2020728>, @aprantl wrote:

> Good point! The reason why I went with `Platform::GetHostPlatform()` over `HostInfo::GetXcodeSDK(sdk))` was because I hadn't realized that I already put a default implementation of GetXcodeSDK into HostInfoBase, and I wanted to avoid guarding this in an ugly `#if APPLE`. But I think that that is completely unnecessary.


Yeah, having a noop implementation in HostInfoBase is consistent with what we do elsewhere, and with llvm support library for that matter (TBE, the support library usually has an additional `bool isFeatureXAvailable()` function and the other functions become `llvm_unreachable` if the feature is really unavailable, but I don't think that's particularly useful for an api with a single entry point).)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79364/new/

https://reviews.llvm.org/D79364