[Lldb-commits] [PATCH] D79384: RFC: Add an API that allows iterating over a debug map's OSO's Modules

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

My understanding is that these OSO modules are supposed to be a hidden implementation detail of SymbolFileDWARF(DebugMap) and that they should not leak out the main module. For example, we make sure to always rewrite any addresses that come out of the oso modules to be in terms of the main module, and ensure that parsed dwarf compile units are assigned to the CompileUnits belonging to the main module, etc.

In that world, the right thing to do would be to ensure that SymbolFileDWARF(DebugMap) accumulates the appropriate sdk information in the main module.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79384/new/

https://reviews.llvm.org/D79384