[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

[Adrian Prantl via Phabricator via lldb-commits]

aprantl created this revision.
aprantl added reviewers: friss, jingham, JDevlieghere, davide.
Herald added a reviewer: jdoerfert.
aprantl updated this revision to Diff 261573.
aprantl added a comment.

Delete more code that is made obsolete by the new API.


When debugging from a SymbolMap the creation of CompileUnits for the
individual object files is so lazy that RegisterXcodeSDK() is not invoked at all
before the Swift TypeSystem wants to read it. This patch fixes this by
introducing an explicit SymbolFile::ParseXcodeSDK() call that can be
invoked deterministically before the result is required.

      

rdar://problem/62532151


https://reviews.llvm.org/D79273

Files:
  lldb/include/lldb/Symbol/SymbolFile.h
  lldb/source/Core/Module.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h
  lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79273.261573.patch
Type: text/x-patch
Size: 6095 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200502/08e887a5/attachment.bin>