[Lldb-commits] [lldb] 232ef38 - [lldb/CommandInterpreter] Fix typo in CommandInterpreterResult::IsResult

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Fri May 1 12:07:28 PDT 2020


Author: Jonas Devlieghere
Date: 2020-05-01T12:07:21-07:00
New Revision: 232ef38713b984cc84d2a009e83c1b044f0c06d3

URL: https://github.com/llvm/llvm-project/commit/232ef38713b984cc84d2a009e83c1b044f0c06d3
DIFF: https://github.com/llvm/llvm-project/commit/232ef38713b984cc84d2a009e83c1b044f0c06d3.diff

LOG: [lldb/CommandInterpreter] Fix typo in CommandInterpreterResult::IsResult

A missing `=` turned a comparison into an assignment.

Added: 
    

Modified: 
    lldb/include/lldb/Interpreter/CommandInterpreter.h
    lldb/source/Interpreter/CommandInterpreter.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Interpreter/CommandInterpreter.h b/lldb/include/lldb/Interpreter/CommandInterpreter.h
index dbe5c186727a..a0a9bcb49969 100644
--- a/lldb/include/lldb/Interpreter/CommandInterpreter.h
+++ b/lldb/include/lldb/Interpreter/CommandInterpreter.h
@@ -38,7 +38,7 @@ class CommandInterpreterRunResult {
   lldb::CommandInterpreterResult GetResult() const { return m_result; }
 
   bool IsResult(lldb::CommandInterpreterResult result) {
-    return m_result = result;
+    return m_result == result;
   }
 
 protected:

diff  --git a/lldb/source/Interpreter/CommandInterpreter.cpp b/lldb/source/Interpreter/CommandInterpreter.cpp
index d765cb7c1a9f..3f727e83f12b 100644
--- a/lldb/source/Interpreter/CommandInterpreter.cpp
+++ b/lldb/source/Interpreter/CommandInterpreter.cpp
@@ -116,7 +116,7 @@ CommandInterpreter::CommandInterpreter(Debugger &debugger,
       m_skip_lldbinit_files(false), m_skip_app_init_files(false),
       m_command_io_handler_sp(), m_comment_char('#'),
       m_batch_command_mode(false), m_truncation_warning(eNoTruncation),
-      m_command_source_depth(0) {
+      m_command_source_depth(0), m_result() {
   SetEventName(eBroadcastBitThreadShouldExit, "thread-should-exit");
   SetEventName(eBroadcastBitResetPrompt, "reset-prompt");
   SetEventName(eBroadcastBitQuitCommandReceived, "quit");


        


More information about the lldb-commits mailing list