[Lldb-commits] [PATCH] D79108: [lldb/CommandInterpreter] Move AutoHandleEvents and SpawnThread into CommandInterpreterRunOptions (NFC)

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 30 12:21:14 PDT 2020


clayborg added inline comments.


================
Comment at: lldb/source/API/SBDebugger.cpp:1190
+    options.SetAutoHandleEvents(auto_handle_events);
+    options.SetSpawnThread(spawn_thread);
     CommandInterpreter &interp = m_opaque_sp->GetCommandInterpreter();
----------------
I agree this is a good idea to do in the header doc. Also might be worth marking this and other functions RunCommandInterpreter as deprecated and point them to the new way of doing things once that patch is in where everything is in SBCommandInterpreterRunOptions and SBCommandInterpreterRunResults


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79108/new/

https://reviews.llvm.org/D79108





More information about the lldb-commits mailing list