[Lldb-commits] [PATCH] D79120: [lldb/API] Add RunCommandInterpreter overload that returns SBCommandInterpreterRunResults (NFC)
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 29 17:50:22 PDT 2020
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Sorry, missed the fact that the new class had ivars. For ABI stability, we can't modify the number of ivars since we need the class size of SBCommandInterpreterRunResults to never change even if we add more things to it.
Comment at: lldb/include/lldb/API/SBCommandInterpreterRunOptions.h:90-93
+ int m_num_errors;
+ bool m_quit_requested;
+ bool m_stopped_for_crash;
We need to abstract these, they can't be in the lldb::SB class. So you just need to make an opaque class that contains these ivar and use a std::unique_ptr to the opaque class.
CHANGES SINCE LAST ACTION
More information about the lldb-commits