[Lldb-commits] [PATCH] D79115: [lldb/API] Move SBCommandInterpreterRunOption in its own header. (NFC)

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, labath.
Herald added a subscriber: mgorny.
JDevlieghere added a parent revision: D79108: [lldb/CommandInterpreter] Move AutoHandleEvents and SpawnThread into CommandInterpreterRunOptions (NFC).

Currently, `SBCommandInterpreterRunOptions ` is defined in `SBCommandInterpreter.h`. Given that the options are always passed by value, a forward declaration of the class as sufficient. That's not the case `SBCommandInterpreterRunResults` if we want to add a new overload `SBCommandInterpreterRunResults RunCommandInterpreter(const SBCommandInterpreterRunOptions &options);.`. We can't include `SBCommandInterpreter.h` because `SBCommandInterpreter::GetDebugger()` returns `SBDebugger` by value and therefore needs a full definition.

My plan is to have both `SBCommandInterpreterRunOptions` and `SBCommandInterpreterRunResults` defined in this file.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D79115

Files:
  lldb/bindings/headers.swig
  lldb/bindings/interface/SBCommandInterpreter.i
  lldb/bindings/interface/SBCommandInterpreterRunOptions.i
  lldb/bindings/interfaces.swig
  lldb/include/lldb/API/SBCommandInterpreter.h
  lldb/include/lldb/API/SBCommandInterpreterRunOptions.h
  lldb/source/API/CMakeLists.txt
  lldb/source/API/SBCommandInterpreter.cpp
  lldb/source/API/SBCommandInterpreterRunOptions.cpp
  lldb/source/API/SBDebugger.cpp
  lldb/source/API/SBReproducer.cpp
  lldb/tools/driver/Driver.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79115.260984.patch
Type: text/x-patch
Size: 26935 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200429/f23ad647/attachment-0001.bin>