[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 27 04:15:22 PDT 2020

labath added a comment.

In D78825#2002598 <https://reviews.llvm.org/D78825#2002598>, @vsk wrote:

> Can we delete an override of SBDebugger::RunCommandInterpreter, or are they all part of the stable API?

They are. The way that has been handled so far is that once a function starts to get too many overloads, we create a overload taking a class like `SBFuncOptions`, which contains all the arguments and is extensible. That seems to have kind of happened here already, as we have the `SBCommandInterpreterRunOptions` class. However, in this case, that struct only contains "input" arguments, which is why I am reluctant to recommend shove output arguments there.

That said, I am wondering about the semantics of the `num_errors` argument. If it is nonzero only in cases where we "stop because of an error" (or we can adjust it so that this is the case), then maybe we don't need a new api for this...




More information about the lldb-commits mailing list