[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

[Med Ismail Bennani via Phabricator via lldb-commits]

mib updated this revision to Diff 260012.
mib added a comment.

After playing with `llvm::sys::swapByteOrder` and the `DataExtractor` getters (GetU8, GetU16, GetU32 ....), it looks like neither of these supports bitfields.

Since the `CFBasicHash` struct relies heavily on bitfields, it won't support mixed endianness.

I changed the patch so if the host and the target have different byte orders,  lldb will abort the data formatting.
I also removed all the DataBuffer and DataExtractor logic since it's not needed anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78396/new/

https://reviews.llvm.org/D78396

Files:
  lldb/source/Plugins/Language/ObjC/CFBasicHash.cpp
  lldb/source/Plugins/Language/ObjC/CFBasicHash.h
  lldb/source/Plugins/Language/ObjC/CMakeLists.txt
  lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
  lldb/source/Plugins/Language/ObjC/NSDictionary.h
  lldb/source/Plugins/Language/ObjC/NSSet.cpp
  lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSContainer.py
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/main.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78396.260012.patch
Type: text/x-patch
Size: 31175 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200424/61a9d04c/attachment-0001.bin>