[Lldb-commits] [lldb] 304ba5d - Delete cargo-cult code that doesn't affect the testsuite.

Davidino Italiano via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 24 12:05:42 PDT 2020



> On Apr 24, 2020, at 11:55 AM, Adrian Prantl via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> 
> Author: Adrian Prantl
> Date: 2020-04-24T11:54:52-07:00
> New Revision: 304ba5d4c6bc48853832e4fc4666f8e37308d7a4
> 
> URL: https://github.com/llvm/llvm-project/commit/304ba5d4c6bc48853832e4fc4666f8e37308d7a4
> DIFF: https://github.com/llvm/llvm-project/commit/304ba5d4c6bc48853832e4fc4666f8e37308d7a4.diff
> 
> LOG: Delete cargo-cult code that doesn't affect the testsuite.
> 
> Added: 
> 
> 
> Modified: 
>    lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
> 
> Removed: 
> 
> 
> 
> ################################################################################
> diff  --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
> index 3446db0b1214..4f35d8ac51f0 100644
> --- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
> +++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
> @@ -1231,11 +1231,6 @@ void TypeSystemClang::SetOwningModule(clang::Decl *decl,
>   decl->setFromASTFile();
>   decl->setOwningModuleID(owning_module.GetValue());
>   decl->setModuleOwnershipKind(clang::Decl::ModuleOwnershipKind::Visible);
> -  if (auto *decl_ctx = llvm::dyn_cast<clang::DeclContext>(decl)) {
> -    decl_ctx->setHasExternalVisibleStorage();
> -    if (auto *ns = llvm::dyn_cast<NamespaceDecl>(decl_ctx))
> -      ns->getPrimaryContext()->setMustBuildLookupTable();
> -  }
> }

Thanks.


More information about the lldb-commits mailing list