[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files
Med Ismail Bennani via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 23 09:43:37 PDT 2020
mib marked 2 inline comments as done.
mib added inline comments.
================
Comment at: lldb/source/Host/common/FileSystem.cpp:504
+ FileSpec file(file_path.getSingleStringRef());
+ return Readable(file_path) && Instance().Open(file, File::eOpenOptionRead);
+}
----------------
shafik wrote:
> Since `file` is a `FileSpec` can't we just use `ReadableByCurrentUser(const FileSpec &file_spec) ` here?
Good catch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78712/new/
https://reviews.llvm.org/D78712
More information about the lldb-commits
mailing list