[Lldb-commits] [lldb] 400b6f2 - [lldb/Test] Add skipIfReproducer for tests that are not expected to work

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2020-04-21T14:42:14-07:00
New Revision: 400b6f2bc53915b61f1ed9408819fa898e4c8941

URL: https://github.com/llvm/llvm-project/commit/400b6f2bc53915b61f1ed9408819fa898e4c8941
DIFF: https://github.com/llvm/llvm-project/commit/400b6f2bc53915b61f1ed9408819fa898e4c8941.diff

LOG: [lldb/Test] Add skipIfReproducer for tests that are not expected to work

Some tests are not expected to work with reproducers, for example tests
that completely circumvent the reproducers (i.e. using the side_effects
Python module) or that rely on changes to the file system.

Added: 
    

Modified: 
    lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
    lldb/test/API/functionalities/inferior-changed/TestInferiorChanged.py
    lldb/test/API/lang/objc/modules-update/TestClangModulesUpdate.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py b/lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
index 77db8f745d7e..9a66df9a798b 100644
--- a/lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
+++ b/lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
@@ -17,12 +17,14 @@ class BreakpointCommandTestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
+    @skipIfReproducer # side_effect bypasses reproducer
     def not_test_breakpoint_command_sequence(self):
         """Test a sequence of breakpoint command add, list, and delete."""
         self.build()
         self.breakpoint_command_sequence()
 
     @skipIf(oslist=["windows"], bugnumber="llvm.org/pr44431")
+    @skipIfReproducer # side_effect bypasses reproducer
     def test_script_parameters(self):
         """Test a sequence of breakpoint command add, list, and delete."""
         self.build()

diff  --git a/lldb/test/API/functionalities/inferior-changed/TestInferiorChanged.py b/lldb/test/API/functionalities/inferior-changed/TestInferiorChanged.py
index 95cdfb5591fa..16ab1aaeb593 100644
--- a/lldb/test/API/functionalities/inferior-changed/TestInferiorChanged.py
+++ b/lldb/test/API/functionalities/inferior-changed/TestInferiorChanged.py
@@ -16,6 +16,7 @@ class ChangedInferiorTestCase(TestBase):
 
     @skipIf(hostoslist=["windows"])
     @no_debug_info_test
+    @skipIfReproducer # VFS is a snapshot.
     def test_inferior_crashing(self):
         """Test lldb reloads the inferior after it was changed during the session."""
         self.build()

diff  --git a/lldb/test/API/lang/objc/modules-update/TestClangModulesUpdate.py b/lldb/test/API/lang/objc/modules-update/TestClangModulesUpdate.py
index e36a2278daac..13820b56688b 100644
--- a/lldb/test/API/lang/objc/modules-update/TestClangModulesUpdate.py
+++ b/lldb/test/API/lang/objc/modules-update/TestClangModulesUpdate.py
@@ -14,6 +14,7 @@ class TestClangModuleUpdate(TestBase):
 
     @skipUnlessDarwin
     @skipIf(debug_info=no_match(["gmodules"]))
+    @skipIfReproducer # VFS is a snapshot.
     def test_expr(self):
         with open(self.getBuildArtifact("module.modulemap"), "w") as f:
             f.write("""