[Lldb-commits] [PATCH] D72698: [lldb] Add method decls to a CXXRecordDecl only after all their properties are defined

Konrad Wilhelm Kleine via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 20 22:45:52 PDT 2020


kwk added a comment.

> The only code that is currently after addDecl is changing whether the special members are
>  defaulted/trivial. I'm not sure if this actually fixes anything but it's more correct than what we
>  did before.

But at least you return immediately after calling `addDecl`.

When trying to see what `VerifyDecl(cxx_method_decl)` does, I noticed that I don't have a `ClangASTContext.cpp` in my source tree. Even grepping for the file in the last 400 revisions didn't show it: `git log --stat -n400 | grep ClangASTContext.cpp`. No luck with github as well: https://github.com/llvm/llvm-project/search?q=ClangASTContext.cpp&unscoped_q=ClangASTContext.cpp. Is that expected?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72698/new/

https://reviews.llvm.org/D72698





More information about the lldb-commits mailing list