[Lldb-commits] [lldb] e128d53 - [lldb/Test] Don't friend std::make_unique

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2020-04-20T11:48:52-07:00
New Revision: e128d5389547571abe04045e14c679517d01d1f6

URL: https://github.com/llvm/llvm-project/commit/e128d5389547571abe04045e14c679517d01d1f6
DIFF: https://github.com/llvm/llvm-project/commit/e128d5389547571abe04045e14c679517d01d1f6.diff

LOG: [lldb/Test] Don't friend std::make_unique

This wasn't a great idea to begin with, as you can't really rely on the
implementation, but since it also doesn't work with MSVC I've just made
the ctors public.

Added: 
    

Modified: 
    lldb/unittests/Utility/ReproducerInstrumentationTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Utility/ReproducerInstrumentationTest.cpp b/lldb/unittests/Utility/ReproducerInstrumentationTest.cpp
index 1a7f21ded9a5..02e4e7e3420b 100644
--- a/lldb/unittests/Utility/ReproducerInstrumentationTest.cpp
+++ b/lldb/unittests/Utility/ReproducerInstrumentationTest.cpp
@@ -73,7 +73,7 @@ inline TestInstrumentationData GetTestInstrumentationData() {
 }
 
 class TestInstrumentationDataRAII {
-private:
+public:
   TestInstrumentationDataRAII(llvm::raw_string_ostream &os) {
     g_registry.emplace();
     g_serializer.emplace(os);
@@ -86,12 +86,6 @@ class TestInstrumentationDataRAII {
     g_deserializer.emplace(buffer);
   }
 
-  friend std::unique_ptr<TestInstrumentationDataRAII>
-  std::make_unique<TestInstrumentationDataRAII>(llvm::raw_string_ostream &os);
-  friend std::unique_ptr<TestInstrumentationDataRAII>
-  std::make_unique<TestInstrumentationDataRAII>(llvm::StringRef &buffer);
-
-public:
   ~TestInstrumentationDataRAII() { Reset(); }
 
   void Reset() {