[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.

I think this is a really good writeup. Thanks for doing this.



================
Comment at: lldb/docs/resources/test.rst:156-157
+of variants. It's very tempting to add more variants because it's an easy way
+to increase test coverage. It doesn't scale. It's cheap in developer time, but
+extremely expensive in terms of runtime and maintenance time because it
+multiplies the overhead.
----------------
As we usually maintain our own tests, I would say "maintenance time" is a subset of "developer time". I guess you wanted to say something like that it's easy to set up, but increases the runtime of the tests and has a large ongoing cost.


================
Comment at: lldb/docs/resources/test.rst:160
+
+The key take away is that the different variants don't prevent the need for
+focused tests. So relying on it to test say DWARF5 is a really bad idea.
----------------
s/prevent/remove (obviate) ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78242/new/

https://reviews.llvm.org/D78242